Hi guys, finally got back to this.
Addressed comments. Perf looks neutral. Have a quick second look, thanks!
--Michael
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js
File test/mjsunit/array-store-and-grow.js (right):
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode192
test/mjsunit/array-store-and-grow.js:192: // case.
On 2013/07/31 09:43:00, Jakob wrote:
nit: missing ')' after 'case'
Done.
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode210
test/mjsunit/array-store-and-grow.js:210: }());
On 2013/07/31 09:43:00, Jakob wrote:
nit: AFAIK the outer parentheses aren't even necessary, but when we do
put them,
we usually put them around the function definition, as in:
(function() {...})();
Done.
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode214
test/mjsunit/array-store-and-grow.js:214: // deopt if you pass an
element out of bounds
On 2013/07/31 09:43:00, Jakob wrote:
nit: trailing full stop
Done.
https://codereview.chromium.org/21058003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
