lgtm with 2 nits.
https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode1111
src/hydrogen.cc:1111: key_checker.ElseDeopt("key out of capacity
range");
Uppercase k
https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode5596
src/hydrogen.cc:5596: FinishExitWithHardDeoptimization(join,
Can we make the reason here also the first argument, just like for all
other methods that get the reason as input?
https://codereview.chromium.org/22339018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
