One comment so far, but could you please merge both HMul/smi related issues
together? They are entirely dependent on each other; so I'd like to review
them
together in one CL.
https://chromiumcodereview.appspot.com/22600005/diff/1/src/hydrogen-canonicalize.cc
File src/hydrogen-canonicalize.cc (right):
https://chromiumcodereview.appspot.com/22600005/diff/1/src/hydrogen-canonicalize.cc#newcode50
src/hydrogen-canonicalize.cc:50:
instr->SetFlag(HInstruction::kAllUsesTruncatingToSmi);
We should probably always set TruncatingToInt32 everywhere where we set
TruncatingToSmi, to ensure we at least have TruncatingToInt32.
https://chromiumcodereview.appspot.com/22600005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
