LGTM (with nits)
https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc#newcode1070
src/bootstrapper.cc:1070: global, "ArrayBuffer", JS_ARRAY_BUFFER_TYPE,
This change should finally make ArrayBuffer.prototype non-writable,
could we add a separate test file to mjsunit that checks that using
something like the following:
Object.getOwnPropertyDescriptor(ArrayBuffer, "prototype")
Lets choose a name for the test suite unrelated to typed arrays (e.g.
mjsunit/function-prototype-primordial.js) as this applies to all
experimental features. Or add it to the mjsunit/function-prototype.js
file.
https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc#newcode1113
src/bootstrapper.cc:1113: }
nit: Add an empty newline here for readability.
https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc#newcode1380
src/bootstrapper.cc:1380:
nit: Only one empty newline here.
https://codereview.chromium.org/22390008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
