Reviewers: Yang,
Message:
Another mind-blowing beauty.
Description:
Remove check for empty handle for CodeGenerator::MakeCodeEpilogue.
[email protected]
Please review this at https://codereview.chromium.org/22840002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/codegen.cc
M src/full-codegen.cc
M src/lithium.cc
Index: src/codegen.cc
diff --git a/src/codegen.cc b/src/codegen.cc
index
2031b321a4bd698223848df9ba7fc0b300fcfe6f..e988810b5742be2d0229bdfe576f5b958417a4de
100644
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -114,11 +114,9 @@ Handle<Code>
CodeGenerator::MakeCodeEpilogue(MacroAssembler* masm,
Handle<Code> code =
isolate->factory()->NewCode(desc, flags, masm->CodeObject(),
false, is_crankshafted);
- if (!code.is_null()) {
- isolate->counters()->total_compiled_code_size()->Increment(
- code->instruction_size());
- code->set_prologue_offset(info->prologue_offset());
- }
+ isolate->counters()->total_compiled_code_size()->Increment(
+ code->instruction_size());
+ code->set_prologue_offset(info->prologue_offset());
return code;
}
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index
f5539e8b18714dc8c9a2703ffac7a24b3de2268f..8846107acf8e90db9e631ca24347f3d5c5d60d57
100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -350,21 +350,17 @@ bool FullCodeGenerator::MakeCode(CompilationInfo*
info) {
code->set_back_edge_table_offset(table_offset);
code->set_back_edges_patched_for_osr(false);
CodeGenerator::PrintCode(code, info);
- info->SetCode(code); // May be an empty handle.
+ info->SetCode(code);
#ifdef ENABLE_GDB_JIT_INTERFACE
- if (FLAG_gdbjit && !code.is_null()) {
+ if (FLAG_gdbjit) {
GDBJITLineInfo* lineinfo =
masm.positions_recorder()->DetachGDBJITLineInfo();
-
GDBJIT(RegisterDetailedLineInfo(*code, lineinfo));
}
#endif
- if (!code.is_null()) {
- void* line_info =
- masm.positions_recorder()->DetachJITHandlerData();
- LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code,
line_info));
- }
- return !code.is_null();
+ void* line_info = masm.positions_recorder()->DetachJITHandlerData();
+ LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code, line_info));
+ return true;
}
Index: src/lithium.cc
diff --git a/src/lithium.cc b/src/lithium.cc
index
790a2182b176ac5d86e701e01395297d90c6e5ca..fa837c7edef2fbbd23f5f7d9f983bd107b76998c
100644
--- a/src/lithium.cc
+++ b/src/lithium.cc
@@ -461,12 +461,10 @@ Handle<Code> LChunk::Codegen() {
CodeGenerator::MakeCodeEpilogue(&assembler, flags, info());
generator.FinishCode(code);
code->set_is_crankshafted(true);
- if (!code.is_null()) {
- void* jit_handler_data =
- assembler.positions_recorder()->DetachJITHandlerData();
- LOG_CODE_EVENT(info()->isolate(),
- CodeEndLinePosInfoRecordEvent(*code,
jit_handler_data));
- }
+ void* jit_handler_data =
+ assembler.positions_recorder()->DetachJITHandlerData();
+ LOG_CODE_EVENT(info()->isolate(),
+ CodeEndLinePosInfoRecordEvent(*code, jit_handler_data));
CodeGenerator::PrintCode(code, info());
return code;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
