LGTM with nits.
See also Ben's comments on https://codereview.chromium.org/22833002/.
https://codereview.chromium.org/22807003/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/22807003/diff/1/src/compiler.cc#newcode451
src/compiler.cc:451:
info_->set_bailout_reason(kBailedOutDueToDependentMap);
same naming nit here
https://codereview.chromium.org/22807003/diff/1/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/22807003/diff/1/src/compiler.h#newcode302
src/compiler.h:302:
!isolate()->optimizing_compiler_thread()->IsOptimizerThread());
IsOptimizerThread contains "if (!FLAG_parallel_recompilation) return
false;", so you don't need the || here.
https://codereview.chromium.org/22807003/diff/1/src/compiler.h#newcode303
src/compiler.h:303: abort_due_to_map_dependency_ = true;
naming nit: could be any dependency change, not just a map.
https://codereview.chromium.org/22807003/diff/1/test/mjsunit/regress/regress-map-invalidation-1.js
File test/mjsunit/regress/regress-map-invalidation-1.js (right):
https://codereview.chromium.org/22807003/diff/1/test/mjsunit/regress/regress-map-invalidation-1.js#newcode1
test/mjsunit/regress/regress-map-invalidation-1.js:1: // Copyright 2012
the V8 project authors. All rights reserved.
nit: 2013
https://codereview.chromium.org/22807003/diff/1/test/mjsunit/regress/regress-map-invalidation-2.js
File test/mjsunit/regress/regress-map-invalidation-2.js (right):
https://codereview.chromium.org/22807003/diff/1/test/mjsunit/regress/regress-map-invalidation-2.js#newcode1
test/mjsunit/regress/regress-map-invalidation-2.js:1: // Copyright 2012
the V8 project authors. All rights reserved.
nit: 2013
https://codereview.chromium.org/22807003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
