Added comments.
https://codereview.chromium.org/22824003/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/22824003/diff/1/src/ia32/lithium-ia32.cc#newcode1907
src/ia32/lithium-ia32.cc:1907: if (to.IsSmiOrTagged()) {
Smi -> Smi doesn't happen, so this is superfluous.
https://codereview.chromium.org/22824003/diff/1/src/ia32/lithium-ia32.cc#newcode1928
src/ia32/lithium-ia32.cc:1928: LNumberUntagD* res = new(zone())
LNumberUntagD(value, temp);
We should probably check the value representation in NumberUntagD as
well?
https://codereview.chromium.org/22824003/diff/1/src/ia32/lithium-ia32.cc#newcode1939
src/ia32/lithium-ia32.cc:1939: if (instr->value()->type().IsSmi()) {
What about val->type().IsSmi() || val->representation().IsSmi() instead
of duplicating code above?
https://codereview.chromium.org/22824003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
