Thanks. :) LGTM, with nits.
https://chromiumcodereview.appspot.com/22795004/diff/1/src/api.cc
File src/api.cc (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/src/api.cc#newcode679
src/api.cc:679: void V8::Eternalize(i::Isolate* isolate, i::Object**
handle, int* index) {
Is there a reason for changing this? I'd keep the functional version if
possible.
https://chromiumcodereview.appspot.com/22795004/diff/1/src/global-handles.h
File src/global-handles.h (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/src/global-handles.h#newcode400
src/global-handles.h:400: void Create(Isolate* isolate, Object* object,
int* index);
Same here.
https://chromiumcodereview.appspot.com/22795004/diff/1/test/cctest/test-global-handles.cc
File test/cctest/test-global-handles.cc (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/test/cctest/test-global-handles.cc#newcode521
test/cctest/test-global-handles.cc:521: // Create an eternal with via
the constructor
Nit: typo?
https://chromiumcodereview.appspot.com/22795004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
