lgtm if you address the nits, but please wait to land until we've opened the
tree again after this week's stability.
https://codereview.chromium.org/21123008/diff/49001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/21123008/diff/49001/src/x64/code-stubs-x64.cc#newcode2464
src/x64/code-stubs-x64.cc:2464:
nit: please remove unrelated whitespace change.
https://codereview.chromium.org/21123008/diff/49001/src/x64/codegen-x64.h
File src/x64/codegen-x64.h (right):
https://codereview.chromium.org/21123008/diff/49001/src/x64/codegen-x64.h#newcode119
src/x64/codegen-x64.h:119: ARGUMENTS_CONTAIN_RECEIVER,
nit: four space indent from previous line.
https://codereview.chromium.org/21123008/diff/49001/src/x64/codegen-x64.h#newcode132
src/x64/codegen-x64.h:132: ARGUMENTS_CONTAIN_RECEIVER,
nit: four space indent from previous line.
https://codereview.chromium.org/21123008/diff/49001/src/x64/codegen-x64.h#newcode146
src/x64/codegen-x64.h:146: int extra_displacement_to_last_argument = 0)
nit: four space indent from previous line.
https://codereview.chromium.org/21123008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
