Addressed comment
https://chromiumcodereview.appspot.com/22152003/diff/17024/src/hydrogen-mark-deoptimize.cc
File src/hydrogen-mark-deoptimize.cc (right):
https://chromiumcodereview.appspot.com/22152003/diff/17024/src/hydrogen-mark-deoptimize.cc#newcode74
src/hydrogen-mark-deoptimize.cc:74: if
(HChange::cast(current)->convert_undefined_to_nan()) {
On 2013/08/13 12:55:03, danno wrote:
shouldn't this method be called "can_context_undefined_to_nan"?
Done.
https://chromiumcodereview.appspot.com/22152003/diff/17024/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/22152003/diff/17024/src/ia32/lithium-codegen-ia32.cc#newcode2480
src/ia32/lithium-codegen-ia32.cc:2480: if
(instr->hydrogen()->representation().IsTagged()) {
The hole never escapes as smi; only as double (nan) and tagged.
On 2013/08/13 12:55:03, danno wrote:
What about smi representations?
https://chromiumcodereview.appspot.com/22152003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
