Reviewers: danno,
Message:
PTAL
Description:
Load size in signed int before making negative.
Please review this at https://chromiumcodereview.appspot.com/23074003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-codegen-ia32.cc
M src/x64/lithium-codegen-x64.cc
Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc
b/src/ia32/lithium-codegen-ia32.cc
index
7753e1d37f362b29655a2513a89e91a608a6e991..c515343f643caacecadd16b9f641661d6b9a4aad
100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -2525,7 +2525,8 @@ void LCodeGen::DoCmpHoleAndBranch(LCmpHoleAndBranch*
instr) {
}
__ add(esp, Immediate(kDoubleSize));
- __ cmp(MemOperand(esp, -sizeof(kHoleNanUpper32)),
Immediate(kHoleNanUpper32));
+ int offset = sizeof(kHoleNanUpper32);
+ __ cmp(MemOperand(esp, -offset), Immediate(kHoleNanUpper32));
EmitBranch(instr, equal);
}
Index: src/x64/lithium-codegen-x64.cc
diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc
index
42c23dbfb7137d08f2b0d1043162f234b01ffae3..abb8c77b5b772cd0440251034944771b8277abd9
100644
--- a/src/x64/lithium-codegen-x64.cc
+++ b/src/x64/lithium-codegen-x64.cc
@@ -2196,9 +2196,8 @@ void LCodeGen::DoCmpHoleAndBranch(LCmpHoleAndBranch*
instr) {
__ movsd(MemOperand(rsp, 0), input_reg);
__ addq(rsp, Immediate(kDoubleSize));
- int size = sizeof(kHoleNanUpper32);
- __ cmpl(MemOperand(rsp, -size),
- Immediate(kHoleNanUpper32));
+ int offset = sizeof(kHoleNanUpper32);
+ __ cmpl(MemOperand(rsp, -offset), Immediate(kHoleNanUpper32));
EmitBranch(instr, equal);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
