Revision: 16193
Author: [email protected]
Date: Wed Aug 14 09:13:58 2013
Log: Fix Crankshafted CompareNil of constant values
[email protected]
Review URL: https://codereview.chromium.org/23198002
http://code.google.com/p/v8/source/detail?r=16193
Added:
/branches/bleeding_edge/test/mjsunit/constant-compare-nil-value.js
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.h
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/constant-compare-nil-value.js Wed
Aug 14 09:13:58 2013
@@ -0,0 +1,42 @@
+// Copyright 2013 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax
+
+function inlined() {
+ return 1;
+}
+
+function foo() {
+ if ((inlined() + 0.5) == null) return "null";
+ return "non-null";
+}
+
+assertEquals("non-null", foo());
+assertEquals("non-null", foo());
+%OptimizeFunctionOnNextCall(foo);
+assertEquals("non-null", foo());
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Wed Aug 14 07:50:15
2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Wed Aug 14 09:13:58
2013
@@ -3230,8 +3230,8 @@
}
bool InstanceOf(Handle<Map> map) {
- return handle_->IsJSObject() &&
- Handle<JSObject>::cast(handle_)->map() == *map;
+ return handle()->IsJSObject() &&
+ Handle<JSObject>::cast(handle())->map() == *map;
}
bool IsSpecialDouble() const {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
