Reviewers: abarth, rossberg,
Description:
Add access check for observed objects
This change is mostly straightforward: for 'normal' sorts of change records,
simply don't deliver a changeRecord to a given observer callback if an
access
the callback's Context is not allowed to [[Get]] changeRecord.name on
changeRecord.object.
For 'splice' records, the question of whether to hand it to an observer is
trickier, since
there are multiple properties involved, and multiple types of possible
information leakage.
Given that access-checked objects are very rare (only two in Blink, Window
and
Location),
and that they are not normally used as Arrays, it seems better to simply not
emit any splice
records for such objects rather than spending lots of logic to attempt to
avoid
information
leakage for something that may never happen.
BUG=v8:2778
Please review this at https://codereview.chromium.org/22962009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/object-observe.js
M src/runtime.h
M src/runtime.cc
M test/cctest/test-object-observe.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
