Reviewers: machenbach, Jakob,
Message:
I agree. I am sorry for adding more exceptions.
Description:
Avoid -O3 in nacl as it does not play well with -W.
Also cleans up some uninitialized data I saw while investigating
the problem.
Please review this at https://codereview.chromium.org/23119004/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M build/toolchain.gypi
M src/effects.h
Index: build/toolchain.gypi
===================================================================
--- build/toolchain.gypi (revision 16180)
+++ build/toolchain.gypi (working copy)
@@ -561,14 +561,22 @@
'cflags!': [
'-O0',
'-O1',
- '-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- '-O3',
],
+ 'conditions': [
+ # TODO(crbug.com/272548): Avoid -O3 in NaCl
+ ['nacl_target_arch=="none"', {
+ 'cflags': ['-O3'],
+ 'cflags!': ['-O2'],
+ }, {
+ 'cflags': ['-O2'],
+ 'cflags!': ['-O3'],
+ }],
+ ]
}],
['v8_optimized_debug!=0 and gcc_version==44 and clang==0', {
'cflags': [
@@ -614,13 +622,11 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
'cflags!': [
- '-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- '-O3',
'<(wno_array_bounds)',
],
'conditions': [
@@ -630,7 +636,15 @@
'-fno-tree-vrp',
],
}],
- ],
+ # TODO(crbug.com/272548): Avoid -O3 in NaCl
+ ['nacl_target_arch=="none"', {
+ 'cflags': ['-O3'],
+ 'cflags!': ['-O2'],
+ }, {
+ 'cflags': ['-O2'],
+ 'cflags!': ['-O3'],
+ }],
+ ]
}],
['OS=="android"', {
'cflags!': [
Index: src/effects.h
===================================================================
--- src/effects.h (revision 16180)
+++ src/effects.h (working copy)
@@ -55,7 +55,7 @@
Modality modality;
Bounds bounds;
- Effect() {}
+ Effect() : modality(DEFINITE) {}
Effect(Bounds b, Modality m = DEFINITE) : modality(m), bounds(b) {}
// The unknown effect.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
