LGTM if one comment if addressed.
https://codereview.chromium.org/22990003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/22990003/diff/1/test/cctest/test-api.cc#newcode9532
test/cctest/test-api.cc:9532: CHECK(!CompileRun("'prototype' in
fun")->BooleanValue());
Can we add an additional check that "fun" actually throws when being
called as a constructor? I was thinking along the lines of the following
two checks ...
v8::TryCatch try_catch;
CompileRun("new fun");
CHECK(try_catch.HasCaught());
try_catch.Reset();
fun->NewInstance();
CHECK(try_catch.HasCaught());
https://codereview.chromium.org/22990003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
