LGTM with a couple of comments.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393
src/hydrogen-instructions.h:3393: bool SameConstantObject(HConstant*
other) {
nit: Let's rename this to just "SameConstant", it doesn't look specific
to objects.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3394
src/hydrogen-instructions.h:3394: if (HasSmiValue() &&
other->HasSmiValue()) {
Shouldn't this be HasInteger32Value in these checks? Also what about
HasDoubleValue?
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc#newcode8028
src/hydrogen.cc:8028: return !right->IsConstant() ||
nit: Should fit into one line.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc#newcode8032
src/hydrogen.cc:8032: return !left->IsConstant() ||
nit: Should fit into one line.
https://codereview.chromium.org/22876009/diff/13001/src/lithium.cc
File src/lithium.cc (right):
https://codereview.chromium.org/22876009/diff/13001/src/lithium.cc#newcode509
src/lithium.cc:509: void LChunkBuilder::PropagateUnreachableBlockMarks()
{
As discussed offline: This looks like it should be done as a separate
hydrogen phase (similar to HPropagateDeoptimizingMarkPhase) instead of
as part of the lithium chunk builder. But I am totally fine with leaving
this for a follow-up CL to cleanup, in which case I would put a TODO
here.
https://codereview.chromium.org/22876009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
