LGTM with two nits to address.
https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1683
src/hydrogen.cc:1683: // Allocate both the JS array and the elements
array in one big
nit: Comment is outdated.
https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1689
src/hydrogen.cc:1689: JS_OBJECT_TYPE);
Nice, that would have been a disaster once we would have pretenured
these.
https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1706
src/hydrogen.cc:1706: // Get hold of the elements array of the
boilerplate and setup the
nit: Comment is outdated.
https://codereview.chromium.org/23038003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
