Nice cleanup, but still unnecessary complex IMHO.
https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8189
src/hydrogen.cc:8189: Handle<JSObject> original_boilerplate_object,
Why does this function take the deep-copied boilerplate _and_ the
original boilerplate. That makes no sense, can we get rid of that? It
should be sufficient to just take a boilerplate.
https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8292
src/hydrogen.cc:8292: Handle<JSObject> original_boilerplate_object,
Likewise.
https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8359
src/hydrogen.cc:8359: Handle<FixedArrayBase> original_elements,
Likewise.
https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8398
src/hydrogen.cc:8398: Handle<FixedArrayBase> original_elements,
Likewise.
https://codereview.chromium.org/23030002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
