Ok, first round of comments.
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683
src/arm/code-stubs-arm.cc:683: // with exponent because Bias + 1 = 1024
which is an *ARM* immediate value.
Please add a STATIC_ASSERT() for this.
https://codereview.chromium.org/23129003/diff/11001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/macro-assembler-arm.h#newcode990
src/arm/macro-assembler-arm.h:990: void
TryInlineTruncateDoubleToI(Register result,
On 2013/08/16 14:43:54, rmcilroy_google wrote:
On 2013/08/16 12:18:19, danno wrote:
> Perhaps make this a private member?
I did this originally, but then needed to call the method from
test-code-stubs-arm.cc. I could make a friend class for the test code
to call,
but the test isn't currently a class itself. Any thoughts?
If there's no easy way to make this private, you should at least add a
comment with reason why this is public.
https://codereview.chromium.org/23129003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
