Revision: 16215
Author: [email protected]
Date: Mon Aug 19 10:55:51 2013 UTC
Log: Clarify side effects of HTransitionElementsKind.
[email protected]
Review URL: https://codereview.chromium.org/22796011
http://code.google.com/p/v8/source/detail?r=16215
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen-instructions.h
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Wed Aug 14
12:14:08 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Mon Aug 19
10:55:51 2013 UTC
@@ -3085,6 +3085,7 @@
ElementsAccessor::ForKind(from_kind)->name(),
*transitioned_map(),
ElementsAccessor::ForKind(to_kind)->name());
+ if (IsSimpleMapChangeTransition(from_kind, to_kind)) stream->Add("
(simple)");
}
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Mon Aug 19 07:25:25
2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Mon Aug 19 10:55:51
2013 UTC
@@ -6265,11 +6265,7 @@
SetOperandAt(1, context);
SetFlag(kUseGVN);
SetGVNFlag(kChangesElementsKind);
- if (original_map->has_fast_double_elements()) {
- SetGVNFlag(kChangesElementsPointer);
- SetGVNFlag(kChangesNewSpacePromotion);
- }
- if (transitioned_map->has_fast_double_elements()) {
+ if (!IsSimpleMapChangeTransition(from_kind_, to_kind_)) {
SetGVNFlag(kChangesElementsPointer);
SetGVNFlag(kChangesNewSpacePromotion);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
