On 2013/08/19 12:44:47, Sven Panne wrote:
https://codereview.chromium.org/23098004/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382
src/globals.h:382: #if __cplusplus >= 201103L
Looking at Chrome's base/compiler_specific.h, I think we can use it more
often:
MSVC supports this for ages (VS2005 at least) and clang supports it. Checking
the C++ version should be used as a fallback.

https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode394
src/globals.h:394: #if __cplusplus >= 201103L
Same here: For MSVC we can fall back to 'sealed', clang has it, otherwise
check
C++ version.

Done.

PTAL

https://chromiumcodereview.appspot.com/23098004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to