Taking this one over from Michael Stanton, since he is on vacation.
https://codereview.chromium.org/22831010/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/22831010/diff/1/include/v8.h#newcode982
include/v8.h:982: enum CompilationType {
We try not to expose internal behavior (and constants) through the API,
especially when they are not use in the API at all.
IIUC, these constants will be used to compare against
Script::compile_type, or to me more precises against
ScriptMirror.prototype.compilationType. This is only available if
debugger support is actually enabled, another reason not to put the
constant into the API.
Would it be possible to add a ScriptMirror.prototype.compiledThroughEval
(or similar name) predicate to do the job? This predicate could then
rely on the JavaScript constants that we have defined in macros.py for
that purpose. Also note that I am not particularly familiar with the
debugger API, so take this suggestion with a grain of salt.
https://codereview.chromium.org/22831010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
