lgtm if you improve the comment as suggested, please wait to land until the
V8
tree is no longer throttled
https://chromiumcodereview.appspot.com/22348005/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://chromiumcodereview.appspot.com/22348005/diff/7001/src/x64/macro-assembler-x64.h#newcode724
src/x64/macro-assembler-x64.h:724: // Push a 64-bit integer as two
"general" Smis on stack so that the garbage
I find the comments a bit confusing. I think the following is probably
clearer:
Save away a 64-bit integer on the stack as two 32-bits integers
masquerading as smis so that the garbage collector skips visiting them.
https://chromiumcodereview.appspot.com/22348005/diff/7001/src/x64/macro-assembler-x64.h#newcode728
src/x64/macro-assembler-x64.h:728: // Reconstruct a 64-bit integer from
two "general" Smis from stack.
// Reconstruct a 64-bit integer from two 32-bits integers masquerading
as smis on the top of stack.
https://chromiumcodereview.appspot.com/22348005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
