On 2013/08/19 18:20:01, Benedikt Meurer wrote:
On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
> LGTM!
> I think we should make the use of FINAL and OVERRIDE mandatory in all
new
code
> (except additions to public API)
Hm, looking through the code again, we should probably use V8_FINAL and
V8_OVERRIDE to avoid collisions with other people's #define's. We already
had
to
redefine one FINAL enum in our own code because of this. Opinions?
Better safe than sorry, properly prefixed with V8_ now.
https://chromiumcodereview.appspot.com/23064017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
