Revision: 16235
Author: [email protected]
Date: Tue Aug 20 08:12:19 2013 UTC
Log: Avoid -O3 in nacl as it does not play well with -W.
Also cleans up some uninitialized data I saw while investigating
the problem.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/23119004
Patch from Ken Mixter <[email protected]>.
http://code.google.com/p/v8/source/detail?r=16235
Modified:
/branches/bleeding_edge/build/toolchain.gypi
/branches/bleeding_edge/src/effects.h
=======================================
--- /branches/bleeding_edge/build/toolchain.gypi Fri Aug 2 10:59:23 2013
UTC
+++ /branches/bleeding_edge/build/toolchain.gypi Tue Aug 20 08:12:19 2013
UTC
@@ -561,13 +561,21 @@
'cflags!': [
'-O0',
'-O1',
- '-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- '-O3',
+ ],
+ 'conditions': [
+ # TODO(crbug.com/272548): Avoid -O3 in NaCl
+ ['nacl_target_arch=="none"', {
+ 'cflags': ['-O3'],
+ 'cflags!': ['-O2'],
+ }, {
+ 'cflags': ['-O2'],
+ 'cflags!': ['-O3'],
+ }],
],
}],
['v8_optimized_debug!=0 and gcc_version==44 and clang==0', {
@@ -614,13 +622,11 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
'cflags!': [
- '-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- '-O3',
'<(wno_array_bounds)',
],
'conditions': [
@@ -630,6 +636,14 @@
'-fno-tree-vrp',
],
}],
+ # TODO(crbug.com/272548): Avoid -O3 in NaCl
+ ['nacl_target_arch=="none"', {
+ 'cflags': ['-O3'],
+ 'cflags!': ['-O2'],
+ }, {
+ 'cflags': ['-O2'],
+ 'cflags!': ['-O3'],
+ }],
],
}],
['OS=="android"', {
=======================================
--- /branches/bleeding_edge/src/effects.h Tue Aug 6 12:57:23 2013 UTC
+++ /branches/bleeding_edge/src/effects.h Tue Aug 20 08:12:19 2013 UTC
@@ -55,7 +55,7 @@
Modality modality;
Bounds bounds;
- Effect() {}
+ Effect() : modality(DEFINITE) {}
Effect(Bounds b, Modality m = DEFINITE) : modality(m), bounds(b) {}
// The unknown effect.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
