Revision: 16237
Author: [email protected]
Date: Tue Aug 20 08:17:43 2013 UTC
Log: Fix null handle deref in InternalDateFormat
[email protected]
Review URL: https://codereview.chromium.org/22927014
http://code.google.com/p/v8/source/detail?r=16237
Modified:
/branches/bleeding_edge/src/runtime.cc
=======================================
--- /branches/bleeding_edge/src/runtime.cc Tue Aug 20 08:07:52 2013 UTC
+++ /branches/bleeding_edge/src/runtime.cc Tue Aug 20 08:17:43 2013 UTC
@@ -13649,7 +13649,7 @@
CONVERT_ARG_HANDLE_CHECKED(JSDate, date, 1);
bool has_pending_exception = false;
- double millis = Execution::ToNumber(date,
&has_pending_exception)->Number();
+ Handle<Object> value = Execution::ToNumber(date, &has_pending_exception);
if (has_pending_exception) {
ASSERT(isolate->has_pending_exception());
return Failure::Exception();
@@ -13660,7 +13660,7 @@
if (!date_format) return isolate->ThrowIllegalOperation();
icu::UnicodeString result;
- date_format->format(millis, result);
+ date_format->format(value->Number(), result);
return *isolate->factory()->NewStringFromTwoByte(
Vector<const uint16_t>(
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
