LGTM.
As discussed offline, we might want to move this to build/features.gypi if
other
targets need those defines as well, but doing so has other drawbacks, so
let's
keep them in v8.gyp for now.
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp#newcode791
tools/gyp/v8.gyp:791: 'V8_OS_BSD=1',
really?
https://codereview.chromium.org/23283010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
