Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Replace OS::MemCopy with memcpy in typed array initialization.
This is an attempt to fix a weird perf regression on MacOS X 10.6 bot.
Perf regression is not reproducible on MacOS X 10.8.
This difference in memory-copying routines is the only reasonable
difference in the algorithm. We should try and see.
[email protected]
BUG=270642
Please review this at https://codereview.chromium.org/23330005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
b26f0102c894cc82739673b0dd57ffb9098ad54a..057e268f7ad0e6ec9f830b449b7963a5eda30934
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -996,7 +996,7 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_TypedArrayInitializeFromArrayLike) {
JSArrayBuffer::cast(typed_array->buffer())->backing_store());
size_t source_byte_offset =
NumberToSize(isolate, typed_array->byte_offset());
- OS::MemCopy(
+ memcpy(
buffer->backing_store(),
backing_store + source_byte_offset,
byte_length);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
