Revision: 16247
Author: [email protected]
Date: Tue Aug 20 13:20:40 2013 UTC
Log: Add warning to cctest when running multiple tests in sequence.
[email protected]
BUG=v8:2848
Review URL: https://codereview.chromium.org/23067008
http://code.google.com/p/v8/source/detail?r=16247
Modified:
/branches/bleeding_edge/test/cctest/cctest.cc
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.cc Tue Aug 20 01:37:09 2013
UTC
+++ /branches/bleeding_edge/test/cctest/cctest.cc Tue Aug 20 13:20:40 2013
UTC
@@ -106,6 +106,13 @@
};
+static void SuggestTestHarness(int tests) {
+ if (tests == 0) return;
+ printf("Running multiple tests in sequence is deprecated and may cause "
+ "bogus failure. Consider using tools/run-tests.py instead.\n");
+}
+
+
int main(int argc, char* argv[]) {
v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
v8::internal::FLAG_harmony_array_buffer = true;
@@ -138,8 +145,8 @@
if (test->enabled()
&& strcmp(test->file(), file) == 0
&& strcmp(test->name(), name) == 0) {
+ SuggestTestHarness(tests_run++);
test->Run();
- tests_run++;
}
test = test->prev();
}
@@ -152,8 +159,8 @@
if (test->enabled()
&& (strcmp(test->file(), file_or_name) == 0
|| strcmp(test->name(), file_or_name) == 0)) {
+ SuggestTestHarness(tests_run++);
test->Run();
- tests_run++;
}
test = test->prev();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
