Hi Haitao,
Thanks for your continued iteration on this CL. I know it's a lot of work,
and I
appreciate you persistence and patience working through some of these trick
issues. I really want to make sure that we get this right, even if it takes
longer, since it will be the foundation of a lot of work in the future. It's
definitely heading in the right direction!
Regards,
Danno
https://chromiumcodereview.appspot.com/21014003/diff/45001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://chromiumcodereview.appspot.com/21014003/diff/45001/src/x64/macro-assembler-x64.cc#newcode990
src/x64/macro-assembler-x64.cc:990: static inline Immediate
SmiToImmediate(Smi* src) {
On 2013/08/20 15:09:30, haitao.feng wrote:
This is what I have done originally at
https://codereview.chromium.org/21014003/patch/1/1005.
Ooops! I'm sorry, I apologize, that's embarrassing.
The old version from 21014003 bothered me a bit because it was #ifdefed,
I think without the #ifdef, I would be less adverse to the old version.
This new version has an "if", which also doesn't seem quite right. So,
adding to the assembler or here is fine, I'll leave it up to you, but it
should be without an #ifdef or if, e.g.
constructor:
explicit Immediate(Smi* value) {
ASSERT(SmiValuesAre31Bits());
value_ = static_cast<int32_t>(reinterpret_cast<intptr_t>(value));
}
helper function:
static inline Immediate SmiToImmediate(Smi* src) {
ASSERT(SmiValuesAre31Bits());
return
Immediate(static_cast<int32_t>(reinterpret_cast<intptr_t>(src)));
}
https://chromiumcodereview.appspot.com/21014003/diff/45001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://chromiumcodereview.appspot.com/21014003/diff/45001/src/x64/macro-assembler-x64.h#newcode383
src/x64/macro-assembler-x64.h:383: virtual bool NeedsCheckMinusZero()
const = 0;
On 2013/08/20 15:09:30, haitao.feng wrote:
I have planned to use it for SmiMul. If the caller is in lithium, we
could avoid
check for minus zero if HValue::kBailoutOnMinusZero flag is false.
Yes, but this is specific to the Mul operation, seems like it could just
be a "MinusZeroHandlingMode" parameter to the SmiMul/SmiDiv macro
assembler instruction?
https://chromiumcodereview.appspot.com/21014003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
