Revision: 16259
Author: [email protected]
Date: Wed Aug 21 13:39:20 2013 UTC
Log: Cleanup FooSpace::VerifyObject and ElementsAccessor::Validate.
[email protected]
Review URL: https://codereview.chromium.org/23273004
http://code.google.com/p/v8/source/detail?r=16259
Modified:
/branches/bleeding_edge/src/elements.cc
/branches/bleeding_edge/src/spaces.cc
=======================================
--- /branches/bleeding_edge/src/elements.cc Mon Jun 3 15:32:22 2013 UTC
+++ /branches/bleeding_edge/src/elements.cc Wed Aug 21 13:39:20 2013 UTC
@@ -581,14 +581,8 @@
// When objects are first allocated, its elements are Failures.
if (fixed_array_base->IsFailure()) return;
if (!fixed_array_base->IsHeapObject()) return;
- Map* map = fixed_array_base->map();
// Arrays that have been shifted in place can't be verified.
- Heap* heap = holder->GetHeap();
- if (map == heap->one_pointer_filler_map() ||
- map == heap->two_pointer_filler_map() ||
- map == heap->free_space_map()) {
- return;
- }
+ if (fixed_array_base->IsFiller()) return;
int length = 0;
if (holder->IsJSArray()) {
Object* length_obj = JSArray::cast(holder)->length();
=======================================
--- /branches/bleeding_edge/src/spaces.cc Wed Jul 31 07:51:46 2013 UTC
+++ /branches/bleeding_edge/src/spaces.cc Wed Aug 21 13:39:20 2013 UTC
@@ -2852,8 +2852,7 @@
// the VerifyObject definition behind VERIFY_HEAP.
void MapSpace::VerifyObject(HeapObject* object) {
- // The object should be a map or a free-list node.
- CHECK(object->IsMap() || object->IsFreeSpace());
+ CHECK(object->IsMap());
}
@@ -2864,16 +2863,12 @@
// the VerifyObject definition behind VERIFY_HEAP.
void CellSpace::VerifyObject(HeapObject* object) {
- // The object should be a global object property cell or a free-list
node.
- CHECK(object->IsCell() ||
- object->map() == heap()->two_pointer_filler_map());
+ CHECK(object->IsCell());
}
void PropertyCellSpace::VerifyObject(HeapObject* object) {
- // The object should be a global object property cell or a free-list
node.
- CHECK(object->IsPropertyCell() ||
- object->map() == heap()->two_pointer_filler_map());
+ CHECK(object->IsPropertyCell());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
