PTAL
https://chromiumcodereview.appspot.com/22831003/diff/1/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://chromiumcodereview.appspot.com/22831003/diff/1/src/hydrogen-escape-analysis.cc#newcode218
src/hydrogen-escape-analysis.cc:218: ASSERT(load->object() == mapcheck);
On 2013/08/21 14:07:56, titzer wrote:
Since a load now only has one input, isn't this assert redundant?
Done.
https://chromiumcodereview.appspot.com/22831003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/22831003/diff/1/src/hydrogen.cc#newcode1225
src/hydrogen.cc:1225: HCheckMaps* checked_value,
On 2013/08/21 14:07:56, titzer wrote:
s/checked_value/checked_object/g ?
Done.
https://chromiumcodereview.appspot.com/22831003/diff/1/src/hydrogen.cc#newcode4602
src/hydrogen.cc:4602: Add<HCheckMaps>(object, types);
The problem is that we have a checkmap, and then we could load the
prototype from the map; but given that it's a constant, we rather just
inline the prototype as a constant directly. An HConstant doesn't have a
dependency; because it's constant anyway.
I agree, the problem is that the prototype is only that constant if the
HCheckMaps of the receiver succeeded. This goes even further however.
When we check the prototype chain, we have a list of
HCheckMaps(HConstant(p), expected_map_for_p);, which can even be removed
(replaced by a code dependency) if the map of p is "stable".
This CL doesn't fix that problem; but it does at least let the
HLoadNamedField below depend on the right mapcheck; the check of the
prototype from which we load the value.
On 2013/08/21 14:07:56, titzer wrote:
I'm not quite sure where the result of this guy should be fed. Who
consumes the
object afterwards?
https://chromiumcodereview.appspot.com/22831003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
