LGTM with a nit, but perhaps wait for Michael's review, too.
https://codereview.chromium.org/22903012/diff/16/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/22903012/diff/16/src/runtime.cc#newcode1966
src/runtime.cc:1966: if (getter->IsUndefined()) {
Tiny nit: Can we extract this if/then/else into a small static helper
function? This would remove the copy-n-paste + avoid the assignments to
getter/setter (which I effectively consider parameters of
Runtime_SetAccessorProperty).
https://codereview.chromium.org/22903012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
