This approach seems pretty complex. As discussed, I'm not sure it's the
right
way to go.
https://codereview.chromium.org/22903028/diff/5001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/22903028/diff/5001/src/ia32/lithium-codegen-ia32.cc#newcode744
src/ia32/lithium-codegen-ia32.cc:744: continue;
As discussed, this seems broken. If we swap input variables downwards,
we'll visit them again and they'll seem like input variables again; and
we won't pop non-input-variables we just swapped. Additionally, in
larger stacks, we'll never manage to get input variables that are being
swapped upwards in the right position.
I also don't like this kind of code at all; it's very hard to
understand.
https://codereview.chromium.org/22903028/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
