On 2013/08/21 10:07:16, Sven Panne wrote:
LGTM if we have test cases for this (I'm relatively sure about this for
the
CpuProfiler, but not about tests for --prof).
I don't think we have tests for --prof except those for the tick-processor
scripts. I tested it manually though and it worked fine.
Also I'm thinking about disabling CpuProfiler when --prof is used. That
would
simplify the profiling logic. I can't imaging a valid use case when we would
need both working simultaneously.
https://codereview.chromium.org/23011029/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
