On 2013/08/23 07:23:55, Yury Semikhatsky wrote:
On 2013/08/23 06:40:27, Benedikt Meurer wrote:
> On 2013/08/23 06:14:51, Yury Semikhatsky wrote:
> > Guys, any objections to this change?
>
> Maybe I'm missing something, but what is the objective here? You're
switching
> the CPU profiler on Mac OS X to use POSIX signals, so most of the Mac
OS X
> specific code you move around here is going away, right?
Correct. But the full picture is the following. A few days ago I realized
that
we could use signals on Mac OS X and came up with the patch changing Mac
OS X
implementation to use signals. That patch is based on the pile of 4 other
changes (including this one which had been sent for review 4 days before
the
CL
about signals) to the CPU profiler that stuck due to V8 tree being closed
for
2
weeks. If possible I'd prefer to just land all that CLs consecutively
instead
of
taking out one of them from the middle of the queue and rebasing all the
following ones trying to merge parts of this change into one of them.
Yeah, sorry, we're not happy with that either.
https://codereview.chromium.org/22908010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
