Reviewers: machenbach,
Message:
These are obsolete now that cctest no longer runs on the GC stress builders.
Description:
Remove hacks for GC stress builders from cctests.
[email protected]
BUG=cctest
Please review this at https://codereview.chromium.org/22861037/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
M test/cctest/test-debug.cc
M test/cctest/test-parsing.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
d20d27c60c6f7d17c00f74756ffc6d7ad8ba7968..b1e82aae224c7d7b08864d7dd61e3acea72e181f
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -12287,9 +12287,6 @@ void ApiTestFuzzer::TearDown() {
// Lets not be needlessly self-referential.
TEST(Threading1) {
- // TODO(mstarzinger): Disabled in GC stress mode for now, we should find
the
- // correct timeout for this an re-enable this test again
- if (i::FLAG_stress_compaction) return;
ApiTestFuzzer::SetUp(ApiTestFuzzer::FIRST_PART);
ApiTestFuzzer::RunAllTests();
ApiTestFuzzer::TearDown();
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index
4382c10d14f46ee218a806cb136524d3ad3da2cb..484eb8e3fb1aabef97521f31bbb3dc113e3fd0ac
100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6643,11 +6643,6 @@ TEST(ScriptCollectedEventContext) {
script_collected_message_count = 0;
v8::HandleScope scope(isolate);
- // TODO(mstarzinger): This test relies explicit GCs being the only
- // ones triggered. Remove this temporary workaround once we skip
- // running cctests on the GC stress builder.
- i::FLAG_gc_interval = -1;
-
v8::Persistent<v8::Context> context;
{
v8::HandleScope scope(isolate);
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index
999fe4c5bdbeb6d1c7e67895a0d85a8803645b7b..2b9adf83818b8ccf14c2b6eaad4ffaf267fc977f
100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1263,10 +1263,6 @@ TEST(ParserSync) {
NULL
};
- // TODO(mstarzinger): Disabled in GC stress mode for now, we should find
the
- // correct timeout for this and re-enable this test again.
- if (i::FLAG_stress_compaction) return;
-
i::Isolate* isolate = i::Isolate::Current();
i::Factory* factory = isolate->factory();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
