On 2013/08/23 10:25:39, Jakob wrote:
LGTM with comment.
https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler.cc#newcode54
test/cctest/test-cpu-profiler.cc:54: delete processor;
You could use SmartPointer<ProfilerEventsProcessor> (see
src/smart-pointers.h)
to avoid manual deletion, but I don't feel strongly about it.
Wow, smart pointers in v8! Didn't know they exist, updated the test.
Is there a reason SmartPointer is used only in compiler.cc ?
https://codereview.chromium.org/23093022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
