Revision: 16291
Author:   [email protected]
Date:     Fri Aug 23 11:10:03 2013 UTC
Log:      Remove hacks for GC stress builders from cctests.

[email protected]
BUG=cctest

Review URL: https://codereview.chromium.org/22861037
http://code.google.com/p/v8/source/detail?r=16291

Modified:
 /branches/bleeding_edge/test/cctest/test-api.cc
 /branches/bleeding_edge/test/cctest/test-debug.cc
 /branches/bleeding_edge/test/cctest/test-parsing.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Wed Aug 21 10:49:29 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-api.cc Fri Aug 23 11:10:03 2013 UTC
@@ -12287,9 +12287,6 @@

 // Lets not be needlessly self-referential.
 TEST(Threading1) {
- // TODO(mstarzinger): Disabled in GC stress mode for now, we should find the
-  // correct timeout for this an re-enable this test again
-  if (i::FLAG_stress_compaction) return;
   ApiTestFuzzer::SetUp(ApiTestFuzzer::FIRST_PART);
   ApiTestFuzzer::RunAllTests();
   ApiTestFuzzer::TearDown();
=======================================
--- /branches/bleeding_edge/test/cctest/test-debug.cc Mon Aug 19 11:10:08 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-debug.cc Fri Aug 23 11:10:03 2013 UTC
@@ -6643,11 +6643,6 @@
   script_collected_message_count = 0;
   v8::HandleScope scope(isolate);

-  // TODO(mstarzinger): This test relies explicit GCs being the only
-  // ones triggered. Remove this temporary workaround once we skip
-  // running cctests on the GC stress builder.
-  i::FLAG_gc_interval = -1;
-
   v8::Persistent<v8::Context> context;
   {
     v8::HandleScope scope(isolate);
=======================================
--- /branches/bleeding_edge/test/cctest/test-parsing.cc Fri Jul 19 09:57:35 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-parsing.cc Fri Aug 23 11:10:03 2013 UTC
@@ -1263,10 +1263,6 @@
     NULL
   };

- // TODO(mstarzinger): Disabled in GC stress mode for now, we should find the
-  // correct timeout for this and re-enable this test again.
-  if (i::FLAG_stress_compaction) return;
-
   i::Isolate* isolate = i::Isolate::Current();
   i::Factory* factory = isolate->factory();

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to