Revision: 16293
Author: [email protected]
Date: Fri Aug 23 11:43:30 2013 UTC
Log: Get rid of duplicated CPU::DebugBreak() method.
We already have OS::DebugBreak(), which does the right thing.
[email protected]
Review URL: https://codereview.chromium.org/22893050
http://code.google.com/p/v8/source/detail?r=16293
Modified:
/branches/bleeding_edge/src/arm/cpu-arm.cc
/branches/bleeding_edge/src/cpu.h
/branches/bleeding_edge/src/ia32/cpu-ia32.cc
/branches/bleeding_edge/src/mips/cpu-mips.cc
/branches/bleeding_edge/src/runtime.cc
/branches/bleeding_edge/src/x64/cpu-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/cpu-arm.cc Fri Jun 28 15:34:48 2013 UTC
+++ /branches/bleeding_edge/src/arm/cpu-arm.cc Fri Aug 23 11:43:30 2013 UTC
@@ -105,15 +105,6 @@
#endif
#endif
}
-
-
-void CPU::DebugBreak() {
-#if !defined (__arm__)
- UNIMPLEMENTED(); // when building ARM emulator target
-#else
- asm volatile("bkpt 0");
-#endif
-}
} } // namespace v8::internal
=======================================
--- /branches/bleeding_edge/src/cpu.h Fri Jan 13 13:09:52 2012 UTC
+++ /branches/bleeding_edge/src/cpu.h Fri Aug 23 11:43:30 2013 UTC
@@ -59,9 +59,6 @@
// Flush instruction cache.
static void FlushICache(void* start, size_t size);
-
- // Try to activate a system level debugger.
- static void DebugBreak();
};
} } // namespace v8::internal
=======================================
--- /branches/bleeding_edge/src/ia32/cpu-ia32.cc Fri Jun 28 15:34:48 2013
UTC
+++ /branches/bleeding_edge/src/ia32/cpu-ia32.cc Fri Aug 23 11:43:30 2013
UTC
@@ -71,20 +71,6 @@
USE(res);
#endif
}
-
-
-void CPU::DebugBreak() {
-#ifdef _MSC_VER
- // To avoid Visual Studio runtime support the following code can be used
- // instead
- // __asm { int 3 }
- __debugbreak();
-#elif defined(__native_client__)
- asm("hlt");
-#else
- asm("int $3");
-#endif
-}
} } // namespace v8::internal
=======================================
--- /branches/bleeding_edge/src/mips/cpu-mips.cc Fri Jun 28 15:34:48 2013
UTC
+++ /branches/bleeding_edge/src/mips/cpu-mips.cc Fri Aug 23 11:43:30 2013
UTC
@@ -86,14 +86,6 @@
Simulator::FlushICache(Isolate::Current()->simulator_i_cache(), start,
size);
#endif // USE_SIMULATOR.
}
-
-
-void CPU::DebugBreak() {
-#ifdef __mips
- asm volatile("break");
-#endif // #ifdef __mips
-}
-
} } // namespace v8::internal
=======================================
--- /branches/bleeding_edge/src/runtime.cc Thu Aug 22 16:14:37 2013 UTC
+++ /branches/bleeding_edge/src/runtime.cc Fri Aug 23 11:43:30 2013 UTC
@@ -12972,7 +12972,7 @@
RUNTIME_FUNCTION(MaybeObject*, Runtime_SystemBreak) {
SealHandleScope shs(isolate);
ASSERT(args.length() == 0);
- CPU::DebugBreak();
+ OS::DebugBreak();
return isolate->heap()->undefined_value();
}
=======================================
--- /branches/bleeding_edge/src/x64/cpu-x64.cc Fri Jun 28 15:34:48 2013 UTC
+++ /branches/bleeding_edge/src/x64/cpu-x64.cc Fri Aug 23 11:43:30 2013 UTC
@@ -71,18 +71,6 @@
USE(res);
#endif
}
-
-
-void CPU::DebugBreak() {
-#ifdef _MSC_VER
- // To avoid Visual Studio runtime support the following code can be used
- // instead
- // __asm { int 3 }
- __debugbreak();
-#else
- asm("int $3");
-#endif
-}
} } // namespace v8::internal
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
