Looks pretty good, except for formatting.
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js
File tools/tickprocessor.js (left):
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js#oldcode33
tools/tickprocessor.js:33:
nit: leave this line in please.
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js#newcode552
tools/tickprocessor.js:552: return null;
nit: indentation
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js#newcode866
tools/tickprocessor.js:866: '--sourceMap': ['sourceMap', null,
For consistency with other arg names, let's call this --source-map.
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js#newcode867
tools/tickprocessor.js:867: 'Specify the source map that should be used
for output']
nit: indentation
https://codereview.chromium.org/22897021/diff/3001/tools/tickprocessor.js#newcode955
tools/tickprocessor.js:955: * Implements Source Map V3 model. See
http://code.google.com/p/closure-compiler/wiki/SourceMaps
This section looks a lot like
http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SourceMap.js.
How about a comment stating the code's origin?
I'd like to suggest that we simply check in an exact copy of that file,
to make
any future updates trivial. But I see that we need several modifications
to make
things work in d8.
Since we need substantial modifications anyway, the code should adhere
to V8
style: 2-space indentation, 80-column lines, opening '{' on the previous
line.
(Compare with existing code.)
Most of the type annotations don't provide value for a human reader, so
they can
be removed. Feel free to keep those that convey non-obvious information.
https://codereview.chromium.org/22897021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
