Reviewers: ,
Message:
Fixes the following build error with older versions of gcc:
v8/include/v8.h:6516: sorry, unimplemented: inlining failed in call to
'v8::Handlev8::Primitive v8::Null(v8::Isolate*)': function not inlinable
Using always_inline is kind of questionable IMO. I wouldn't mind if you
rejected this patch and removed it altogether.
On a side note, I like the new v8config.h file. Props to whoever wrote
that.
Description:
v8: fix 'inlining failed' build error with gcc 4.2
Please review this at https://codereview.chromium.org/22867047/
Affected files:
M include/v8config.h
Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index
fe72c954289c2951ac8231be93362b606ba503a5..aa24eebff50bb193543295723c9195ece613b8ec
100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -147,7 +147,10 @@
# endif
# define V8_HAS_ATTRIBUTE___ALIGNED__ (V8_GNUC_PREREQ(2, 95, 0))
-# define V8_HAS_ATTRIBUTE_ALWAYS_INLINE (V8_GNUC_PREREQ(4, 0, 0))
+// always_inline is available in gcc 4.0 but not very reliable until 4.4.
+// Works around "sorry, unimplemented: inlining failed" build errors with
+// older compilers.
+# define V8_HAS_ATTRIBUTE_ALWAYS_INLINE (V8_GNUC_PREREQ(4, 4, 0))
# define V8_HAS_ATTRIBUTE_DEPRECATED (V8_GNUC_PREREQ(3, 4, 0))
# define V8_HAS_ATTRIBUTE_VISIBILITY (V8_GNUC_PREREQ(4, 3, 0))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
