Revision: 16312
Author: [email protected]
Date: Mon Aug 26 08:10:10 2013 UTC
Log: Deprecate CpuProfileNode::GetSelfSamplesCount
This method is being replaced by GetHitCount.
BUG=267595
[email protected]
Review URL: https://codereview.chromium.org/22295009
http://code.google.com/p/v8/source/detail?r=16312
Modified:
/branches/bleeding_edge/include/v8-profiler.h
/branches/bleeding_edge/test/cctest/test-cpu-profiler.cc
=======================================
--- /branches/bleeding_edge/include/v8-profiler.h Fri Aug 9 07:38:26 2013
UTC
+++ /branches/bleeding_edge/include/v8-profiler.h Mon Aug 26 08:10:10 2013
UTC
@@ -75,7 +75,7 @@
/** DEPRECATED. Please use GetHitCount instead.
* Returns the count of samples where function was currently executing.
*/
- double GetSelfSamplesCount() const;
+ V8_DEPRECATED(double GetSelfSamplesCount() const);
/**
* Returns the count of samples where the function was currently
executing.
=======================================
--- /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Mon Aug 26
07:17:12 2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Mon Aug 26
08:10:10 2013 UTC
@@ -1372,13 +1372,11 @@
const v8::CpuProfileNode* programNode =
GetChild(root, ProfileGenerator::kProgramEntryName);
CHECK_EQ(0, programNode->GetChildrenCount());
- CHECK_GE(programNode->GetSelfSamplesCount(), 3);
CHECK_GE(programNode->GetHitCount(), 3);
const v8::CpuProfileNode* idleNode =
GetChild(root, ProfileGenerator::kIdleEntryName);
CHECK_EQ(0, idleNode->GetChildrenCount());
- CHECK_GE(idleNode->GetSelfSamplesCount(), 3);
CHECK_GE(idleNode->GetHitCount(), 3);
cpu_profiler->DeleteAllCpuProfiles();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
