Hi Hannes, have a look at my comments, thx!
https://codereview.chromium.org/22915007/diff/5001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22915007/diff/5001/src/hydrogen-instructions.cc#newcode3244
src/hydrogen-instructions.cc:3244: if
(dominator_allocate_instr->type().Equals(HType::JSArray()) &&
Actually here could you make use of Map::CanTrackAllocationSite(), or at
least extend/generalize that function to also work with an HType? That
is a centralized place for deciding which types have "the right" to use
allocation mementos.
https://codereview.chromium.org/22915007/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22915007/diff/5001/src/hydrogen-instructions.h#newcode5149
src/hydrogen-instructions.h:5149: bool clear_next_map_word_;
Actually, do you need this boolean, since you handle things directly
during the dominance walk.
https://codereview.chromium.org/22915007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
