https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc#newcode2364
src/mips/lithium-mips.cc:2364: HEnvironment* env =
current_block_->last_environment();
Can we factor out this code to a platform-independent helper, maybe in a
static method on the HEscapeAnalysisPhase class?
https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/escape-analysis.js
File test/mjsunit/compiler/escape-analysis.js (right):
https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/escape-analysis.js#newcode137
test/mjsunit/compiler/escape-analysis.js:137: // Test deoptimization
with captured objects on operand stack.
Do we need to test modifications of the captured objects between
assertions here as well?
https://codereview.chromium.org/22819011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
