https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (left):
https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.cc#oldcode3932
src/hydrogen-instructions.cc:3932: instr->SetGVNFlag(kDependsOnMaps);
Can a map transition have side effects other than just changing that one
word in the header of that object, e.g. change the layout of an object,
thus invalidating a previously loaded value?
https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.cc#newcode3907
src/hydrogen-instructions.cc:3907: // Negative property indices are
in-object properties, indexed
I think I prefer the if; the logic gets too twisted otherwise.
https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/23241027/diff/1/src/hydrogen-instructions.h#newcode5592
src/hydrogen-instructions.h:5592: class OffsetField : public
BitField<int, 7, 26> {};
Not gonna fit in 32 anymore, unless you shrink the offset yet more :(
https://chromiumcodereview.appspot.com/23241027/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
