LGTM with comments.
https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc#newcode12022
src/runtime.cc:12022: if (frame_it.done()) {
you could use RUNTIME_CHECK(!frame_it.done()) here.
https://codereview.chromium.org/23264015/diff/5001/test/mjsunit/debug-stepin-positions.js
File test/mjsunit/debug-stepin-positions.js (right):
https://codereview.chromium.org/23264015/diff/5001/test/mjsunit/debug-stepin-positions.js#newcode43
test/mjsunit/debug-stepin-positions.js:43: if (event ==
Debug.DebugEvent.Break || event == Debug.DebugEvent.Exception) {
80 char limit.
https://codereview.chromium.org/23264015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
