Reviewers: Jakob,
Description:
Filler sizes have to be Smis, fix x64 breakage.
BUG=
Please review this at https://codereview.chromium.org/23577002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
07e78f3368e251ea89cd57d81d6045a8e873f4b7..6f13b5ced97e7092e04292b8950ec548fce38a39
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -3296,7 +3296,11 @@ void HAllocate::HandleSideEffectDominator(GVNFlag
side_effect,
}
HInstruction* new_dominator_size_constant =
HConstant::CreateAndInsertBefore(
- zone, context(), new_dominator_size, dominator_allocate);
+ zone,
+ context(),
+ new_dominator_size,
+ Representation::None(),
+ dominator_allocate);
dominator_allocate->UpdateSize(new_dominator_size_constant);
#ifdef VERIFY_HEAP
@@ -3394,6 +3398,7 @@ void HAllocate::UpdateFreeSpaceFiller(int32_t
free_space_size) {
context(),
filler_free_space_size_->value()->GetInteger32Constant() +
free_space_size,
+ Representation::Smi(),
filler_free_space_size_);
filler_free_space_size_->UpdateValue(new_free_space_size);
}
@@ -3420,9 +3425,10 @@ void HAllocate::CreateFreeSpaceFiller(int32_t
free_space_size) {
store_map->InsertAfter(filler_map);
HConstant* filler_size = HConstant::CreateAndInsertAfter(
- zone, context(), free_space_size, store_map);
+ zone, context(), free_space_size, Representation::Smi(), store_map);
HObjectAccess access =
- HObjectAccess::ForJSObjectOffset(FreeSpace::kSizeOffset);
+ HObjectAccess::ForJSObjectOffset(FreeSpace::kSizeOffset,
+ Representation::Smi());
HStoreNamedField* store_size = HStoreNamedField::New(zone, context(),
free_space_instr, access, filler_size);
store_size->SetFlag(HValue::kHasNoObservableSideEffects);
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
8668793c8a3e4844783ca40d1ad1a1cc054f6829..af954de4e90186573414e79cc26889e89035f2c7
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -3246,8 +3246,10 @@ class HConstant V8_FINAL : public
HTemplateInstruction<0> {
static HConstant* CreateAndInsertAfter(Zone* zone,
HValue* context,
int32_t value,
+ Representation representation,
HInstruction* instruction) {
- HConstant* new_constant = HConstant::New(zone, context, value);
+ HConstant* new_constant =
+ HConstant::New(zone, context, value, representation);
new_constant->InsertAfter(instruction);
return new_constant;
}
@@ -3255,8 +3257,10 @@ class HConstant V8_FINAL : public
HTemplateInstruction<0> {
static HConstant* CreateAndInsertBefore(Zone* zone,
HValue* context,
int32_t value,
+ Representation representation,
HInstruction* instruction) {
- HConstant* new_constant = HConstant::New(zone, context, value);
+ HConstant* new_constant =
+ HConstant::New(zone, context, value, representation);
new_constant->InsertBefore(instruction);
return new_constant;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
