LGTM with comments.
https://codereview.chromium.org/23577002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/23577002/diff/1/src/hydrogen-instructions.cc#newcode3401
src/hydrogen-instructions.cc:3401: Representation::Smi(),
I'd like a comment here, please. Roughly:
We must explicitly force Smi representation for this constant, because
on x64 we would otherwise automatically choose int32, but the actual
store requires a Smi-tagged value.
https://codereview.chromium.org/23577002/diff/1/src/hydrogen-instructions.cc#newcode3428
src/hydrogen-instructions.cc:3428: zone, context(), free_space_size,
Representation::Smi(), store_map);
Consider repeating the comment here, or an abbreviated version:
// Must force Smi representation for x64 (see comment above).
https://codereview.chromium.org/23577002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
