Reviewers: Sven Panne,
Message:
Hey Sven,
This is the weird dummy_ thing we're talking about.
-- Benedikt
Description:
Drop unused and undocumented dummy_ from SaveContext.
Also remove the obsolte __GNUC_VERSION__ #define.
Please review this at https://codereview.chromium.org/23522003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/isolate-inl.h
M src/isolate.h
M src/platform.h
Index: src/isolate-inl.h
diff --git a/src/isolate-inl.h b/src/isolate-inl.h
index
9fb16fbe96d90066a8b9fee8f7af334ec760b7c9..ddb15806a29504fff278fecf49a0337c4b1459b4
100644
--- a/src/isolate-inl.h
+++ b/src/isolate-inl.h
@@ -39,9 +39,6 @@ namespace internal {
SaveContext::SaveContext(Isolate* isolate) :
prev_(isolate->save_context()) {
if (isolate->context() != NULL) {
context_ = Handle<Context>(isolate->context());
-#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300
- dummy_ = Handle<Context>(isolate->context());
-#endif
}
isolate->set_save_context(this);
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index
3d42cadcedeca17382d62eca327de4818c90f4bf..751f9953c0d174cd62b10a4f9d298ca6ef238d13
100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1406,9 +1406,6 @@ class SaveContext BASE_EMBEDDED {
private:
Handle<Context> context_;
-#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300
- Handle<Context> dummy_;
-#endif
SaveContext* prev_;
Address c_entry_fp_;
};
Index: src/platform.h
diff --git a/src/platform.h b/src/platform.h
index
10a7e2c92e516be43f7286451b5de739ecedfe8e..3576d8348416056ed229e25c2d4f5c37315799a8
100644
--- a/src/platform.h
+++ b/src/platform.h
@@ -58,13 +58,6 @@ int signbit(double x);
# endif
#endif
-// GCC specific stuff
-#ifdef __GNUC__
-
-#define __GNUC_VERSION__ (__GNUC__ * 10000 + __GNUC_MINOR__ * 100)
-
-#endif // __GNUC__
-
// Microsoft Visual C++ specific stuff.
#if V8_CC_MSVC
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
